Remove tp from pipline argument list
#947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimoire
reviewed
Jan 15, 2024
| tp = kwargs['tp'] | ||
| kwargs.pop('tp') | ||
| else: | ||
| tp = 1 if backend_config is None else backend_config.tp |
There was a problem hiding this comment.
tp = kwargs.pop('tp', 1) if backend_config is None else backend_config.tpThere was a problem hiding this comment.
不管 backend_config 是不是为空，只要 kwargs 中有 tp，都得pop出来。否则的话，接下来调用AsyncEngine的时候，可能出现 multi tp
grimoire
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.