Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Support auto detect torch_dtype in chat.py #250

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[Bug] Support auto detect torch_dtype in chat.py #250

merged 3 commits into from
Nov 30, 2023

Conversation

HIT-cwh
Copy link
Collaborator

@HIT-cwh HIT-cwh commented Nov 30, 2023

No description provided.

@LZHgrla LZHgrla self-requested a review November 30, 2023 04:15
LZHgrla
LZHgrla reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@LZHgrla LZHgrla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use TORCH_DTYPE_MAP.keys()

others LGTM!

xtuner/tools/chat.py Outdated Show resolved Hide resolved
@HIT-cwh @LZHgrla
Update xtuner/tools/chat.py
629fb63 
Co-authored-by: Zhihao Lin <36994684+LZHgrla@users.noreply.github.com>
@LZHgrla LZHgrla merged commit 092a3fd into InternLM:main Nov 30, 2023
1 check passed
@HIT-cwh HIT-cwh deleted the fix_torch_dtype branch January 31, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LZHgrla LZHgrla LZHgrla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HIT-cwh @LZHgrla