Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Refine Quick Start #378

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Conversation

fanqiNO1
Copy link
Contributor

No description provided.

Copy link

@Gennadiyev Gennadiyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the efforts made in drafting this documentation & would like to suggest several minor format-related changes to the documentation (see details).

I suggest inserting external website URLs to this quickstart to ensure a more informative presentation in favor of the users. ModelScope and HuggingFace should be have hyperlinks to the corresponding model checkpoints to provide a seamless experience to the end developers.

Looking forward to seeing these adjustments incorporated, and I'm here to assist further if needed!

docs/zh_cn/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/zh_cn/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/zh_cn/get_started/quickstart.md Outdated Show resolved Hide resolved
@LZHgrla LZHgrla self-assigned this Feb 26, 2024
Copy link
Collaborator

@LZHgrla LZHgrla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fanqiNO1 Hi,
Thanks for your contribution.

I left some comments, please assess if they are appropriate, and feel free to contact me if you need any help!

docs/en/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/en/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/en/get_started/quickstart.md Show resolved Hide resolved
docs/en/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/en/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/en/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/en/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/en/get_started/quickstart.md Show resolved Hide resolved
docs/zh_cn/get_started/quickstart.md Outdated Show resolved Hide resolved
docs/zh_cn/get_started/quickstart.md Show resolved Hide resolved
@fanqiNO1
Copy link
Contributor Author

Thanks, I will fix it ASAP.

@fanqiNO1
Copy link
Contributor Author

fanqiNO1 commented Mar 2, 2024

I have fixed it, but it seems that the failure of lint is not my fault. 😂

image

@LZHgrla LZHgrla merged commit d994fb6 into InternLM:docs Mar 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants