Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] Reorg xtuner/configs/llava/ configs #483

Merged
merged 5 commits into from
Mar 18, 2024
Merged

[Improve] Reorg xtuner/configs/llava/ configs #483

merged 5 commits into from
Mar 18, 2024

Conversation

LZHgrla
Copy link
Collaborator

@LZHgrla LZHgrla commented Mar 15, 2024 •
edited

  1. Add xtuner/configs/llava/official/
  2. Remove full fine-tuing configs of xtuner's models (such as LLaVA-InternLM2)
  3. Introduce training / evaluation steps with LLaVA-InternLM2 instead of LLaVA-InternLM
  4. Introduce configs structure in README.md

@LZHgrla LZHgrla changed the title [Improve] Add llava_v15_official configs [Improve] Add llava/official configs Mar 15, 2024
bobo0810
bobo0810 approved these changes Mar 15, 2024
View reviewed changes
Copy link

@bobo0810 bobo0810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile is more aligned with llava and I can't wait to get ready to reproduce the metrics @LZHgrla

@LZHgrla LZHgrla changed the title [Improve] Add llava/official configs [Improve] Reorg xtuner/configs/llava/ Mar 15, 2024
@LZHgrla LZHgrla changed the title [Improve] Reorg xtuner/configs/llava/ [Improve] Reorg xtuner/configs/llava/ configs Mar 15, 2024
@pppppM pppppM merged commit 4f91874 into InternLM:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo0810 bobo0810 bobo0810 approved these changes

@pppppM pppppM pppppM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LZHgrla @bobo0810 @pppppM