Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align asset/dataset terminology #189

Conversation

juliapampus
Copy link
Contributor

@juliapampus juliapampus commented Dec 14, 2023

Closes #187

Changed asset to dataset. Removed occurences of IDS.

Copy link
Member

@mkollenstart mkollenstart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

README.md Outdated Show resolved Hide resolved
catalog/catalog.protocol.md Outdated Show resolved Hide resolved
model/terminology.md Outdated Show resolved Hide resolved
model/terminology.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@matgnt matgnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added questions regarding number of offers per dataset.

model/model.md Outdated Show resolved Hide resolved
model/model.md Show resolved Hide resolved
@juliapampus juliapampus requested review from matgnt, jimmarino and mkollenstart and removed request for jimmarino December 14, 2023 14:14
@matgnt
Copy link
Collaborator

matgnt commented Dec 14, 2023

That was fast @juliapampus ;-) you already updated the relevant part :-) Thanks!

@juliapampus juliapampus merged commit eadbaa0 into International-Data-Spaces-Association:main Dec 14, 2023
@juliapampus juliapampus deleted the chore/187_asset_to_dataset branch December 14, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change asset to dataset
4 participants