Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revied setters to eliminate warning in IDE #16

Merged
merged 1 commit into from Nov 3, 2014
Merged

Revied setters to eliminate warning in IDE #16

merged 1 commit into from Nov 3, 2014

Conversation

biancini
Copy link
Contributor

@biancini biancini commented Nov 3, 2014

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

mchyzer added a commit that referenced this pull request Nov 3, 2014
@mchyzer
Merge pull request #16 from biancini/master
8b13f18 
Revied setters to eliminate warning in IDE
@mchyzer mchyzer merged commit 8b13f18 into Internet2:master Nov 3, 2014
@mchyzer
Copy link
Contributor

mchyzer commented Nov 3, 2014

Thanks Andrea!

I thought we discussed this going to the v2_2 branch, but your pull requests were to master. I copied them back to v2_2. Also each change should have a jira, so I created you one:

https://bugs.internet2.edu/jira/browse/GRP-1066

Looks good.

Regards,
Chris

From: Andrea Biancini [mailto:notifications@github.com]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

You can merge this Pull Request by running

git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

#16

Commit Summary

  • Revied setters to eliminate warning in IDE

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/16.

@mchyzer
Copy link
Contributor

mchyzer commented Nov 3, 2014

Hi Chris,
yes sorry for the commit on master. At Indianapolis we talked about having
it placed on some branch on 2.1...
But I actually had some problems and I ended up committing to master.
Thanks for merging with 2.2.

Regarding the Jira, thanks for the link.
Do I have to do anything more?
Testing/validation/verification?

Cheers,
Andrea

On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer mchyzer@isc.upenn.edu wrote:

Thanks Andrea!

I thought we discussed this going to the v2_2 branch, but your pull
requests were to master. I copied them back to v2_2. Also each change
should have a jira, so I created you one:

https://bugs.internet2.edu/jira/browse/GRP-1066

Looks good.

Regards,

Chris

From: Andrea Biancini [mailto:notifications@github.com]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

You can merge this Pull Request by running

git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

#16
Commit Summary

  • Revied setters to eliminate warning in IDE

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#16.

Andrea Biancini

e-mail: andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com
tel: +39 333 2930873

@mchyzer
Copy link
Contributor

mchyzer commented Nov 3, 2014

You are the one using it, so if it works for you, its fine for me ☺ Testing the WS are kind of a pain, but if you have time at some point we can add some similar to the Grouper WS tests. Let me know at some point and I can help you get started…

Thanks,
Chris

From: grouper-dev-request@internet2.edu [mailto:grouper-dev-request@internet2.edu] On Behalf Of Andrea Biancini
Sent: Monday, November 03, 2014 9:05 AM
To: Chris Hyzer
Cc: Internet2/grouper; Internet2/grouper; grouper-dev@internet2.edu
Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)

Hi Chris,
yes sorry for the commit on master. At Indianapolis we talked about having it placed on some branch on 2.1...
But I actually had some problems and I ended up committing to master.
Thanks for merging with 2.2.

Regarding the Jira, thanks for the link.
Do I have to do anything more?
Testing/validation/verification?

Cheers,
Andrea

On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer <mchyzer@isc.upenn.edumailto:mchyzer@isc.upenn.edu> wrote:
Thanks Andrea!

I thought we discussed this going to the v2_2 branch, but your pull requests were to master. I copied them back to v2_2. Also each change should have a jira, so I created you one:

https://bugs.internet2.edu/jira/browse/GRP-1066

Looks good.

Regards,
Chris

From: Andrea Biancini [mailto:notifications@github.commailto:notifications@github.com]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

You can merge this Pull Request by running

git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

#16

Commit Summary

  • Revied setters to eliminate warning in IDE

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/16.

Andrea Biancini

e-mail: andrea.biancini@gmail.commailto:andrea.biancini@gmail.com
web: andrea.biancini.googlepages.comhttp://andrea.biancini.googlepages.com
tel: +39 333 2930873

@biancini
Copy link
Contributor Author

biancini commented Nov 3, 2014

Thanks Chris,
honestly, I'm quite the test guy. In fact I think that with a proper design
testing we could be able to evaluate and accept contributions more easily
in the code streamline.

So, even if this is not for sure a priority activity, whenever you can we
could discuss the test strategy and the test approach you implemented for
grouper-ws.
If you can help me get started I can try to implement a full test case
suite also for this VOOT connector!

A.

On Mon, Nov 3, 2014 at 3:32 PM, mchyzer notifications@github.com wrote:

You are the one using it, so if it works for you, its fine for me ☺
Testing the WS are kind of a pain, but if you have time at some point we
can add some similar to the Grouper WS tests. Let me know at some point and
I can help you get started…

Thanks,
Chris

From: grouper-dev-request@internet2.edu [mailto:
grouper-dev-request@internet2.edu] On Behalf Of Andrea Biancini
Sent: Monday, November 03, 2014 9:05 AM
To: Chris Hyzer
Cc: Internet2/grouper; Internet2/grouper; grouper-dev@internet2.edu
Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate
warning in IDE (#16)

Hi Chris,
yes sorry for the commit on master. At Indianapolis we talked about having
it placed on some branch on 2.1...
But I actually had some problems and I ended up committing to master.
Thanks for merging with 2.2.

Regarding the Jira, thanks for the link.
Do I have to do anything more?
Testing/validation/verification?

Cheers,
Andrea

On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer <mchyzer@isc.upenn.edu<mailto:
mchyzer@isc.upenn.edu>> wrote:
Thanks Andrea!

I thought we discussed this going to the v2_2 branch, but your pull
requests were to master. I copied them back to v2_2. Also each change
should have a jira, so I created you one:

https://bugs.internet2.edu/jira/browse/GRP-1066

Looks good.

Regards,
Chris

From: Andrea Biancini [mailto:notifications@github.com<mailto:
notifications@github.com>]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

You can merge this Pull Request by running

git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

#16

Commit Summary

  • Revied setters to eliminate warning in IDE

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub<
https://github.com/Internet2/grouper/pull/16>.

Andrea Biancini

e-mail: andrea.biancini@gmail.commailto:andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com<
http://andrea.biancini.googlepages.com>
tel: +39 333 2930873

—
Reply to this email directly or view it on GitHub
#16 (comment).

Andrea Biancini

e-mail: andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com
tel: +39 333 2930873

@mchyzer
Copy link
Contributor

mchyzer commented Nov 3, 2014

Uh, volunteering to write tests???? Yes please!

Can you please work in v2_2? I wrote a sample test there that works for me:

30ca9ee

Note, that will delete your registry since it extends GrouperTest. This is best so the registry is blank, test will be repeatable.

I use eclipse and that project has grouper-ws as a dependency which has “grouper” as a dependency, which is why the API and junit.jar etc are available…

Note, this doesn’t actually test the HTTP traffic and servlet, but it tests the business logic which I think is fine for now since the servlet works and shouldn’t change much, ok? If you want we can add an end to end test later on…

Thanks,
Chris

From: Andrea Biancini [mailto:notifications@github.com]
Sent: Monday, November 03, 2014 11:26 AM
To: Internet2/grouper
Cc: Chris Hyzer
Subject: Re: [grouper] Revied setters to eliminate warning in IDE (#16)

Thanks Chris,
honestly, I'm quite the test guy. In fact I think that with a proper design
testing we could be able to evaluate and accept contributions more easily
in the code streamline.

So, even if this is not for sure a priority activity, whenever you can we
could discuss the test strategy and the test approach you implemented for
grouper-ws.
If you can help me get started I can try to implement a full test case
suite also for this VOOT connector!

A.

On Mon, Nov 3, 2014 at 3:32 PM, mchyzer <notifications@github.commailto:notifications@github.com> wrote:

You are the one using it, so if it works for you, its fine for me ☺
Testing the WS are kind of a pain, but if you have time at some point we
can add some similar to the Grouper WS tests. Let me know at some point and
I can help you get started…

Thanks,
Chris

From: grouper-dev-request@internet2.edumailto:grouper-dev-request@internet2.edu [mailto:
grouper-dev-request@internet2.edumailto:grouper-dev-request@internet2.edu] On Behalf Of Andrea Biancini
Sent: Monday, November 03, 2014 9:05 AM
To: Chris Hyzer
Cc: Internet2/grouper; Internet2/grouper; grouper-dev@internet2.edumailto:grouper-dev@internet2.edu
Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate
warning in IDE (#16)

Hi Chris,
yes sorry for the commit on master. At Indianapolis we talked about having
it placed on some branch on 2.1...
But I actually had some problems and I ended up committing to master.
Thanks for merging with 2.2.

Regarding the Jira, thanks for the link.
Do I have to do anything more?
Testing/validation/verification?

Cheers,
Andrea

On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer <mchyzer@isc.upenn.edu<mailto:
mailto:mchyzer@isc.upenn.edu%3cmailto:%20%0b> mchyzer@isc.upenn.edumailto:mchyzer@isc.upenn.edu>> wrote:
Thanks Andrea!

I thought we discussed this going to the v2_2 branch, but your pull
requests were to master. I copied them back to v2_2. Also each change
should have a jira, so I created you one:

https://bugs.internet2.edu/jira/browse/GRP-1066

Looks good.

Regards,
Chris

From: Andrea Biancini [mailto:notifications@github.com<mailto:
notifications@github.com>mailto:notifications@github.com%3cmailto:%20%0b%3e%20notifications@github.com%3e]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

You can merge this Pull Request by running

git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

#16

Commit Summary

  • Revied setters to eliminate warning in IDE

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub<
https://github.com/Internet2/grouper/pull/16>.

Andrea Biancini

e-mail: andrea.biancini@gmail.commailto:andrea.biancini@gmail.commailto:andrea.biancini@gmail.com%3cmailto:andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com<
http://andrea.biancini.googlepages.com>
tel: +39 333 2930873

—
Reply to this email directly or view it on GitHub
#16 (comment).

Andrea Biancini

e-mail: andrea.biancini@gmail.commailto:andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com
tel: +39 333 2930873

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/16#issuecomment-61504074.

@mchyzer
Copy link
Contributor

mchyzer commented Nov 3, 2014

Thanks Chris,
it seems quite clear to me!
So I have to configure a Grouper on my development workstation to have the
tests running?
Tomorrow (here in Italy is 7pm) I will try to start and go through it!

One last question, I have this problem on GROUPER_2_2_BRANCH (see attached
picture).
It seems that some source path is missing in grouper-ws. Should I lik those
folder to some other in the worskspace?
How should I correct this?

Thansk!
A.

On Mon, Nov 3, 2014 at 6:59 PM, Chris Hyzer mchyzer@isc.upenn.edu wrote:

Uh, volunteering to write tests???? Yes please!

Can you please work in v2_2? I wrote a sample test there that works for
me:

30ca9ee

Note, that will delete your registry since it extends GrouperTest. This
is best so the registry is blank, test will be repeatable.

I use eclipse and that project has grouper-ws as a dependency which has
“grouper” as a dependency, which is why the API and junit.jar etc are
available…

Note, this doesn’t actually test the HTTP traffic and servlet, but it
tests the business logic which I think is fine for now since the servlet
works and shouldn’t change much, ok? If you want we can add an end to end
test later on…

Thanks,

Chris

From: Andrea Biancini [mailto:notifications@github.com]
Sent: Monday, November 03, 2014 11:26 AM
To: Internet2/grouper
Cc: Chris Hyzer
Subject: Re: [grouper] Revied setters to eliminate warning in IDE (#16)

Thanks Chris,
honestly, I'm quite the test guy. In fact I think that with a proper
design
testing we could be able to evaluate and accept contributions more easily
in the code streamline.

So, even if this is not for sure a priority activity, whenever you can we
could discuss the test strategy and the test approach you implemented for
grouper-ws.
If you can help me get started I can try to implement a full test case
suite also for this VOOT connector!

A.

On Mon, Nov 3, 2014 at 3:32 PM, mchyzer notifications@github.com wrote:

You are the one using it, so if it works for you, its fine for me ☺
Testing the WS are kind of a pain, but if you have time at some point we
can add some similar to the Grouper WS tests. Let me know at some point
and
I can help you get started…

Thanks,
Chris

From: grouper-dev-request@internet2.edu [mailto:
grouper-dev-request@internet2.edu] On Behalf Of Andrea Biancini
Sent: Monday, November 03, 2014 9:05 AM
To: Chris Hyzer
Cc: Internet2/grouper; Internet2/grouper; grouper-dev@internet2.edu
Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate
warning in IDE (#16)

Hi Chris,
yes sorry for the commit on master. At Indianapolis we talked about
having
it placed on some branch on 2.1...
But I actually had some problems and I ended up committing to master.
Thanks for merging with 2.2.

Regarding the Jira, thanks for the link.
Do I have to do anything more?
Testing/validation/verification?

Cheers,
Andrea

On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer <mchyzer@isc.upenn.edu<mailto:

<mchyzer@isc.upenn.edu%3cmailto:%20%0b>> mchyzer@isc.upenn.edu>> wrote:

Thanks Andrea!

I thought we discussed this going to the v2_2 branch, but your pull
requests were to master. I copied them back to v2_2. Also each change
should have a jira, so I created you one:

https://bugs.internet2.edu/jira/browse/GRP-1066

Looks good.

Regards,
Chris

From: Andrea Biancini [mailto:notifications@github.com<mailto:
notifications@github.com>
<notifications@github.com%3cmailto:%20%0b%3e%20notifications@github.com%3e>]

Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

You can merge this Pull Request by running

git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

#16

Commit Summary

  • Revied setters to eliminate warning in IDE

File Changes

  • M

grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootEmail.java<

https://github.com/Internet2/grouper/pull/16/files#diff-0> (16)

  • M

grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootGroup.java<

https://github.com/Internet2/grouper/pull/16/files#diff-1> (24)

  • M

grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootPerson.java<

https://github.com/Internet2/grouper/pull/16/files#diff-2> (24)

  • M

grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootErrorResponse.java<

https://github.com/Internet2/grouper/pull/16/files#diff-3> (12)

  • M

grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetGroupsResponse.java<

https://github.com/Internet2/grouper/pull/16/files#diff-4> (16)

  • M

grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetMembersResponse.java<

https://github.com/Internet2/grouper/pull/16/files#diff-5> (16)

  • M

grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootResponse.java<

https://github.com/Internet2/grouper/pull/16/files#diff-6> (18)

Patch Links:

—
Reply to this email directly or view it on GitHub<
https://github.com/Internet2/grouper/pull/16>.

Andrea Biancini

e-mail: andrea.biancini@gmail.commailto:andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com<
http://andrea.biancini.googlepages.com>
tel: +39 333 2930873

—
Reply to this email directly or view it on GitHub
#16 (comment).

Andrea Biancini

e-mail: andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com
tel: +39 333 2930873

—
Reply to this email directly or view it on GitHub
#16 (comment).

Andrea Biancini

e-mail: andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com
tel: +39 333 2930873

@mchyzer
Copy link
Contributor

mchyzer commented Nov 3, 2014

Uh, yeah ☺ You can link source for those vars so they point to your source dirs, but if you arent changing grouper API code or client code, you can just remove them probably. Just don’t commit your changes to the .project file. Here is an example if you set them up:

[cid:image001.png@01CFF76F.B650E8A0]

Or if you manually edit the grouper-ws .project file (again, don’t commit it), and enter the paths on your machine, and close the project (delete but not contents), and import again, it should work:

   <variableList>
          <variable>
                 <name>GROUPER_V2_2_CLIENT_SOURCE</name>
                 <value>file:/C:/Users/mchyzer/Documents/GitHub/grouper_v2_2/grouper-misc/grouperClient/src/java</value>
          </variable>
          <variable>
                 <name>GROUPER_V2_2_CONF</name>
                 <value>file:/C:/Users/mchyzer/Documents/GitHub/grouper_v2_2/grouper/conf</value>
          </variable>
          <variable>
                 <name>GROUPER_V2_2_SOURCE</name>
                 <value>file:/C:/Users/mchyzer/Documents/GitHub/grouper_v2_2/grouper/src/grouper</value>
          </variable>
   </variableList>

From: Andrea Biancini [mailto:andrea.biancini@gmail.com]
Sent: Monday, November 03, 2014 1:16 PM
To: Chris Hyzer
Cc: Internet2/grouper; Internet2/grouper; grouper-dev@internet2.edu
Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)

Thanks Chris,
it seems quite clear to me!
So I have to configure a Grouper on my development workstation to have the tests running?
Tomorrow (here in Italy is 7pm) I will try to start and go through it!

One last question, I have this problem on GROUPER_2_2_BRANCH (see attached picture).
It seems that some source path is missing in grouper-ws. Should I lik those folder to some other in the worskspace?
How should I correct this?

Thansk!
A.

On Mon, Nov 3, 2014 at 6:59 PM, Chris Hyzer <mchyzer@isc.upenn.edumailto:mchyzer@isc.upenn.edu> wrote:
Uh, volunteering to write tests???? Yes please!

Can you please work in v2_2? I wrote a sample test there that works for me:

30ca9ee

Note, that will delete your registry since it extends GrouperTest. This is best so the registry is blank, test will be repeatable.

I use eclipse and that project has grouper-ws as a dependency which has “grouper” as a dependency, which is why the API and junit.jar etc are available…

Note, this doesn’t actually test the HTTP traffic and servlet, but it tests the business logic which I think is fine for now since the servlet works and shouldn’t change much, ok? If you want we can add an end to end test later on…

Thanks,
Chris

From: Andrea Biancini [mailto:notifications@github.commailto:notifications@github.com]
Sent: Monday, November 03, 2014 11:26 AM
To: Internet2/grouper
Cc: Chris Hyzer
Subject: Re: [grouper] Revied setters to eliminate warning in IDE (#16)

Thanks Chris,
honestly, I'm quite the test guy. In fact I think that with a proper design
testing we could be able to evaluate and accept contributions more easily
in the code streamline.

So, even if this is not for sure a priority activity, whenever you can we
could discuss the test strategy and the test approach you implemented for
grouper-ws.
If you can help me get started I can try to implement a full test case
suite also for this VOOT connector!

A.

On Mon, Nov 3, 2014 at 3:32 PM, mchyzer <notifications@github.commailto:notifications@github.com> wrote:

You are the one using it, so if it works for you, its fine for me ☺
Testing the WS are kind of a pain, but if you have time at some point we
can add some similar to the Grouper WS tests. Let me know at some point and
I can help you get started…

Thanks,
Chris

From: grouper-dev-request@internet2.edumailto:grouper-dev-request@internet2.edu [mailto:
grouper-dev-request@internet2.edumailto:grouper-dev-request@internet2.edu] On Behalf Of Andrea Biancini
Sent: Monday, November 03, 2014 9:05 AM
To: Chris Hyzer
Cc: Internet2/grouper; Internet2/grouper; grouper-dev@internet2.edumailto:grouper-dev@internet2.edu
Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate
warning in IDE (#16)

Hi Chris,
yes sorry for the commit on master. At Indianapolis we talked about having
it placed on some branch on 2.1...
But I actually had some problems and I ended up committing to master.
Thanks for merging with 2.2.

Regarding the Jira, thanks for the link.
Do I have to do anything more?
Testing/validation/verification?

Cheers,
Andrea

On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer <mchyzer@isc.upenn.edu<mailto:
mailto:mchyzer@isc.upenn.edu%3cmailto:%20%0b> mchyzer@isc.upenn.edumailto:mchyzer@isc.upenn.edu>> wrote:
Thanks Andrea!

I thought we discussed this going to the v2_2 branch, but your pull
requests were to master. I copied them back to v2_2. Also each change
should have a jira, so I created you one:

https://bugs.internet2.edu/jira/browse/GRP-1066

Looks good.

Regards,
Chris

From: Andrea Biancini [mailto:notifications@github.com<mailto:
notifications@github.com>mailto:notifications@github.com%3cmailto:%20%0b%3e%20notifications@github.com%3e]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

You can merge this Pull Request by running

git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

#16

Commit Summary

  • Revied setters to eliminate warning in IDE

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub<
https://github.com/Internet2/grouper/pull/16>.

Andrea Biancini

e-mail: andrea.biancini@gmail.commailto:andrea.biancini@gmail.commailto:andrea.biancini@gmail.com%3cmailto:andrea.biancini@gmail.com
web: andrea.biancini.googlepages.comhttp://andrea.biancini.googlepages.com<
http://andrea.biancini.googlepages.com>
tel: +39 333 2930873tel:%2B39%20333%202930873

—
Reply to this email directly or view it on GitHub
#16 (comment).

Andrea Biancini

e-mail: andrea.biancini@gmail.commailto:andrea.biancini@gmail.com
web: andrea.biancini.googlepages.comhttp://andrea.biancini.googlepages.com
tel: +39 333 2930873tel:%2B39%20333%202930873

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/16#issuecomment-61504074.

Andrea Biancini

e-mail: andrea.biancini@gmail.commailto:andrea.biancini@gmail.com
web: andrea.biancini.googlepages.comhttp://andrea.biancini.googlepages.com
tel: +39 333 2930873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@biancini @mchyzer