Allow to inspect reward accounts wrt #46 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Aug 17, 2020
There was a problem hiding this comment.
The PR should come with additional tests cases covering this two new cases. See existing scenarios in: https://github.com/input-output-hk/cardano-addresses/blob/master/command-line/test/Command/Address/InspectSpec.hs#L17
hasufell
force-pushed
the
hasufell/46/inspect-reward-acc-addr
branch
from
c782fbd
to
17dfc99
Compare
done |
|
To consider: allowing to generate these addresses via cardano-addresses. |
6 tasks
KtorZ
approved these changes
Aug 18, 2020
hasufell
force-pushed
the
hasufell/46/inspect-reward-acc-addr
branch
from
17dfc99
to
af91818
Compare
Anviking
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 25, 2020
Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59)
1 task
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 25, 2020
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
Anviking
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 25, 2020
Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59)
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 25, 2020
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 25, 2020
2066: Bump cardano-addresses r=rvl a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 25, 2020
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 26, 2020
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 26, 2020
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 26, 2020
2066: Bump cardano-addresses r=KtorZ a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2080: Also trace the times of stake distribution LSQ queries r=Anviking a=Anviking # Issue Number #2005 / new issue # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Also measure and trace the times of the LSQ queries in the `stakeDistribution` function # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 26, 2020
2066: Bump cardano-addresses r=KtorZ a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 28, 2020
2066: Bump cardano-addresses r=rvl a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2071: Minor nix cleanups r=rvl a=rvl ### Issue Number #2046 #2054 ### Overview - Minor cleanups of nix code for migration tests and latency benchmark. ### Comments Tested with: ``` nix-build -A benchmarks.cardano-wallet.latency nix-build nix/migration-tests.nix ``` 2080: Also trace the times of stake distribution LSQ queries r=rvl a=Anviking # Issue Number #2005 / new issue # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Also measure and trace the times of the LSQ queries in the `stakeDistribution` function # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2087: Transaction metadata in swagger API spec r=rvl a=rvl ### Issue Number ADP-307 / #2073 / #2074 ### Overview Updates the swagger spec for the new metadata field when: - listing transactions (metadata field is always present but may be null) - posting a transaction (metadata field is optional) - estimating fee (as above) ### Comments [Rendered spec](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/input-output-hk/cardano-wallet/rvl/2073/swagger/specifications/api/swagger.yaml) Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 28, 2020
2066: Bump cardano-addresses r=rvl a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2071: Minor nix cleanups r=rvl a=rvl ### Issue Number #2046 #2054 ### Overview - Minor cleanups of nix code for migration tests and latency benchmark. ### Comments Tested with: ``` nix-build -A benchmarks.cardano-wallet.latency nix-build nix/migration-tests.nix ``` Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 28, 2020
2066: Bump cardano-addresses r=rvl a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Aug 30, 2020
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run:
Built: