Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol parameters conversion errors propagation #1

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 18, 2023

Description

cardano-api changes split off from: IntersectMBO/cardano-node#5197

This PR also includes #3 , so you should review only the latest related commit.

Changelog

- description: |
    Added `genValidProtocolParameters` generator producing `ProtocolParameters` which do pass
    validations in `Cardano.Api.ProtocolParameters` module.  Remove `Cardano.Api.Orphans` from public API.
  compatibility: breaking
  type: [feature, test]

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@carbolymer carbolymer marked this pull request as draft May 18, 2023 13:09
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from 817fea8 to dc954ec Compare May 18, 2023 13:12
@carbolymer carbolymer changed the title #5092 Protocol parameters conversion errors propagation - cardano-api #5092 Protocol parameters conversion errors propagation May 18, 2023
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from dc954ec to 4d1f8c0 Compare May 18, 2023 13:40
@carbolymer carbolymer marked this pull request as ready for review May 18, 2023 13:49
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from 4d1f8c0 to 44e7bc9 Compare May 18, 2023 14:41
@carbolymer carbolymer changed the title #5092 Protocol parameters conversion errors propagation Protocol parameters conversion errors propagation May 18, 2023
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch 3 times, most recently from 7e59cae to ed09bcc Compare May 19, 2023 13:36
@newhoggy
Copy link
Collaborator

Please add an item into the changelog for any publicly visible changes. gen library is considered a public API.

@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch 2 times, most recently from 387bbfd to 46bed93 Compare May 22, 2023 15:01
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from 46bed93 to b544ffd Compare May 22, 2023 16:00
@carbolymer carbolymer added this pull request to the merge queue May 22, 2023
Merged via the queue into main with commit 436c4b8 May 22, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants