-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol parameters conversion errors propagation #1
Merged
carbolymer
merged 1 commit into
main
from
mgalazyn/feature/remove-applicationname-applicationversion-cfg-params
May 22, 2023
Merged
Protocol parameters conversion errors propagation #1
carbolymer
merged 1 commit into
main
from
mgalazyn/feature/remove-applicationname-applicationversion-cfg-params
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
requested review from
dcoutts,
Jimbo4350,
erikd and
newhoggy
as code owners
May 18, 2023 13:09
carbolymer
force-pushed
the
mgalazyn/feature/remove-applicationname-applicationversion-cfg-params
branch
from
May 18, 2023 13:12
817fea8
to
dc954ec
Compare
carbolymer
changed the title
#5092 Protocol parameters conversion errors propagation - cardano-api
#5092 Protocol parameters conversion errors propagation
May 18, 2023
carbolymer
force-pushed
the
mgalazyn/feature/remove-applicationname-applicationversion-cfg-params
branch
from
May 18, 2023 13:40
dc954ec
to
4d1f8c0
Compare
9 tasks
carbolymer
force-pushed
the
mgalazyn/feature/remove-applicationname-applicationversion-cfg-params
branch
from
May 18, 2023 14:41
4d1f8c0
to
44e7bc9
Compare
carbolymer
changed the title
#5092 Protocol parameters conversion errors propagation
Protocol parameters conversion errors propagation
May 18, 2023
carbolymer
force-pushed
the
mgalazyn/feature/remove-applicationname-applicationversion-cfg-params
branch
3 times, most recently
from
May 19, 2023 13:36
7e59cae
to
ed09bcc
Compare
newhoggy
approved these changes
May 22, 2023
newhoggy
approved these changes
May 22, 2023
Please add an item into the changelog for any publicly visible changes. |
Jimbo4350
approved these changes
May 22, 2023
newhoggy
reviewed
May 22, 2023
newhoggy
approved these changes
May 22, 2023
carbolymer
force-pushed
the
mgalazyn/feature/remove-applicationname-applicationversion-cfg-params
branch
2 times, most recently
from
May 22, 2023 15:01
387bbfd
to
46bed93
Compare
carbolymer
force-pushed
the
mgalazyn/feature/remove-applicationname-applicationversion-cfg-params
branch
from
May 22, 2023 16:00
46bed93
to
b544ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cardano-api changes split off from: IntersectMBO/cardano-node#5197
This PR also includes #3 , so you should review only the latest related commit.
Changelog
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7