Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handleFileForWritingWithOwnerPermissionImpl: Fix permisions #141

Merged
merged 3 commits into from Jul 27, 2023
Merged

handleFileForWritingWithOwnerPermissionImpl: Fix permisions #141

merged 3 commits into from Jul 27, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Jul 27, 2023 •
edited

Changelog

- description: |
    Fix permissions of file written using handleFileForWritingWithOwnerPermissionImpl
  compatibility: no-api-changes
  type: bugfix

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@erikd erikd mentioned this pull request Jul 27, 2023
Closed
10 tasks
@erikd
handleFileForWritingWithOwnerPermissionImpl: Fix permisions
9486f80 
In commit ccd4b1a, this function was
modified to allow the use of `unix >= 2.8`, but that broke the permissions
of the created file (which must be owner only). This commit fixes it and
@johnky added a test in the previous commit.
@erikd erikd enabled auto-merge July 27, 2023 03:41
@erikd erikd added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 8eba775 Jul 27, 2023
23 checks passed
@erikd erikd deleted the erikd/posix-compat branch July 27, 2023 04:08
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
@disassembler
Merge pull request #141 from input-output-hk/sl/bump-chap
aebdcce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikd @newhoggy