Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent feature constraints. New IsShelleyToBabbageEra and ConwayEraOnwards type classes #159

Merged
merged 1 commit into from Aug 1, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jul 31, 2023

Changelog

- description: |
    Add parent feature constraints. New `IsShelleyToBabbageEra` and `ConwayEraOnwards` type classes.
  compatibility: compatible
  type: feature

Context

This means that shelleyBasedEraConstraints gives you all the constraints that cardanoEraConstraints gives so you don't have to call both functions.

Likewise:

  • shelleyToBabbageEraConstraints gives you all the constraints of both shelleyBasedEraConstraints and cardanoEraConstraints.

  • conwayEraOnwardsConstraints gives you all the constraints of both shelleyBasedEraConstraints and cardanoEraConstraints.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review July 31, 2023 14:27
@newhoggy newhoggy added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 667698f Aug 1, 2023
25 of 26 checks passed
@newhoggy newhoggy deleted the newhoggy/add-parent-feature-constraints branch August 1, 2023 00:58
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…erts-instead-of-reg

Fix deregistration-certificate: generate deregistration instead of registration certs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants