Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EraCast Certificate #170

Merged
merged 5 commits into from Aug 4, 2023
Merged

Fix EraCast Certificate #170

merged 5 commits into from Aug 4, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Aug 4, 2023

Changelog

- description: |
    Fix `EraCast Certificate`
  compatibility: no-api-changes
  type: bugfix

Context

EraCast Certificate needs to be able to cast certificates between eras.

In future, the ledger will support this, however it is not available at the moment.

This PR implements the logic in cardano-api.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer
Copy link
Contributor

carbolymer commented Aug 4, 2023

This should fix IntersectMBO/cardano-cli#135

@newhoggy newhoggy marked this pull request as ready for review August 4, 2023 09:14
@newhoggy newhoggy force-pushed the newhoggy/fix-EraCast-Certificate branch from ea91f88 to 084f8dc Compare August 4, 2023 09:47
@newhoggy newhoggy changed the title Fix Era Certificate for the case where era does not cross into Conway… Fix EraCast Certificate Aug 4, 2023
@newhoggy newhoggy force-pushed the newhoggy/fix-EraCast-Certificate branch from 084f8dc to 9389d4f Compare August 4, 2023 11:51
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, far better that what I was thinking of.

@Jimbo4350 Jimbo4350 mentioned this pull request Aug 4, 2023
10 tasks
@newhoggy newhoggy enabled auto-merge August 4, 2023 13:23
@newhoggy newhoggy added this pull request to the merge queue Aug 4, 2023
Merged via the queue into main with commit 4f8be44 Aug 4, 2023
17 checks passed
@newhoggy newhoggy deleted the newhoggy/fix-EraCast-Certificate branch August 4, 2023 14:32
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…ased-pparams

Add create-protocol-parameters-update command to era based commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants