Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated functions and types #173

Merged
merged 1 commit into from Aug 14, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Aug 4, 2023

Changelog

- description: |
    Delete deprecated functions and types
  type:
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
    - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here.

If the PR fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review August 4, 2023 16:18
@newhoggy newhoggy force-pushed the newhoggy/delete-deprecated-functions-and-types branch from 4c23d2e to 4fd962b Compare August 5, 2023 07:42
@newhoggy newhoggy force-pushed the newhoggy/delete-deprecated-functions-and-types branch from 4fd962b to 2f335d9 Compare August 14, 2023 02:36
@newhoggy newhoggy force-pushed the newhoggy/delete-deprecated-functions-and-types branch from 2f335d9 to b82295d Compare August 14, 2023 10:29
@newhoggy newhoggy added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 2ce94aa Aug 14, 2023
20 checks passed
@newhoggy newhoggy deleted the newhoggy/delete-deprecated-functions-and-types branch August 14, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants