Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameterisation of GovernanceActionId #192

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

newhoggy
Copy link
Collaborator

Changelog

- description: |
    Fix parameterisation of `GovernanceActionId`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

The GovernanceActionId newtype was parameterised on ledgerera which is wrong. It is inconsistent with other newtypes and later on in the new ledger integration branch, it interferes with the introduction of ToCBOR and FromCBOR instances that are needed to store this data in the vote file.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review August 15, 2023 14:13
@newhoggy newhoggy added this pull request to the merge queue Aug 15, 2023
Merged via the queue into main with commit 1ac0fb7 Aug 15, 2023
23 checks passed
@newhoggy newhoggy deleted the newhoggy/fix-parameterisation-of-GovernanceActionId branch August 15, 2023 14:47
newhoggy added a commit that referenced this pull request Mar 11, 2024
Move legacy errors out of legacy command structure modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants