Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mapSomeAddressVerification key function #225

Merged

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Sep 2, 2023

Changelog

- description: |
    New `foldSomeAddressVerification` key function
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This function is is defined in cardano-cli. Moving it here because it fits with the type declaration.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/new-foldSomeAddressVerificationKey-function branch from a16dc3e to ae9f3b5 Compare September 2, 2023 09:11
@newhoggy newhoggy marked this pull request as ready for review September 2, 2023 09:14
@newhoggy newhoggy force-pushed the newhoggy/new-foldSomeAddressVerificationKey-function branch from ae9f3b5 to ef14e4a Compare September 4, 2023 12:12
@newhoggy newhoggy changed the title New foldSomeAddressVerification key function New mapSomeAddressVerification key function Sep 4, 2023
@newhoggy newhoggy added this pull request to the merge queue Sep 4, 2023
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Sep 4, 2023
@carbolymer carbolymer merged commit e836caf into main Sep 4, 2023
21 checks passed
@carbolymer carbolymer deleted the newhoggy/new-foldSomeAddressVerificationKey-function branch September 4, 2023 15:52
newhoggy added a commit that referenced this pull request Mar 11, 2024
…delegation-certificate-option

Prefix complex delegation certificate option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants