Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New era casing functions #232

Merged
merged 2 commits into from Sep 12, 2023
Merged

New era casing functions #232

merged 2 commits into from Sep 12, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Sep 9, 2023

Changelog

- description: |
    New functions:
    * `caseByronOrShelleyBasedEra`
    * `caseShelleyToMaryOrAlonzoEraOnwards`
    * `caseShelleyToAlonzoOrBabbageEraOnwards`
    Renamed `caseShelleyToBabbageAndConwayEraOnwards` to `caseShelleyToBabbageOrConwayEraOnwards`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Add new era casing functions.

Some example uses are included.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/new-era-casing-functions branch from 94ebadd to 0c333c8 Compare September 9, 2023 06:14
@newhoggy newhoggy marked this pull request as ready for review September 9, 2023 06:27

fromShelleyCertificate =
caseShelleyToBabbageOrConwayEraOnwards
(\w -> shelleyToBabbageEraConstraints w $ ShelleyRelatedCertificate w)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to move these constraint functions into caseShelleyToBabbageOrConwayEraOnwards?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this and see if this is possible in a new PR.

…rds to caseShelleyToBabbageOrConwayEraOnwards
@newhoggy newhoggy force-pushed the newhoggy/new-era-casing-functions branch from 0c333c8 to 2c5e371 Compare September 12, 2023 06:03
@newhoggy newhoggy added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 9f1e6cf Sep 12, 2023
20 checks passed
@newhoggy newhoggy deleted the newhoggy/new-era-casing-functions branch September 12, 2023 08:39
newhoggy added a commit that referenced this pull request Mar 11, 2024
…n-command-implementation-into-era-based

Move `address` run command implementation into era-based
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants