Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose constraints from casing functions #237

Merged
merged 1 commit into from Sep 12, 2023
Merged

Expose constraints from casing functions #237

merged 1 commit into from Sep 12, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Sep 12, 2023 •
edited

Changelog

- description: |
    Expose constraints from casing functions
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This means callers don't have to summon constraints separately.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/expose-constraints-from-casing-functions branch from 39e188c to c9655b8 Compare September 12, 2023 10:17
@newhoggy newhoggy marked this pull request as ready for review September 12, 2023 10:24
Jimbo4350
Jimbo4350 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

cardano-api/internal/Cardano/Api/LedgerState.hs
@@ -1638,8 +1636,8 @@ currentEpochEligibleLeadershipSlots sbe sGen eInfo pp ptclState poolid (VrfSigni
$ Set.fromList [firstSlotOfEpoch .. lastSlotofEpoch]

caseShelleyToAlonzoOrBabbageEraOnwards
(\w -> shelleyToAlonzoEraConstraints w $ isLeadingSlotsTPraos (slotRangeOfInterest pp) poolid setSnapshotPoolDistr epochNonce vrkSkey f)
(\w -> babbageEraOnwardsConstraints w $ isLeadingSlotsPraos (slotRangeOfInterest pp) poolid setSnapshotPoolDistr epochNonce vrkSkey f)
(const (isLeadingSlotsTPraos (slotRangeOfInterest pp) poolid setSnapshotPoolDistr epochNonce vrkSkey f))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@newhoggy newhoggy added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit fcfe1a2 Sep 12, 2023
21 checks passed
@newhoggy newhoggy deleted the newhoggy/expose-constraints-from-casing-functions branch September 12, 2023 14:10
newhoggy added a commit that referenced this pull request Mar 11, 2024
@newhoggy
Merge pull request #237 from input-output-hk/newhoggy/move-key-run-co…
57b5e4e 
…mmands-implementation-into-era-based

Move `key` run commands implementation into era based
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newhoggy @Jimbo4350