Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update chaps index #24

Merged
merged 1 commit into from
May 25, 2023
Merged

update chaps index #24

merged 1 commit into from
May 25, 2023

Conversation

JaredCorduan
Copy link
Contributor

@JaredCorduan JaredCorduan commented May 25, 2023 •
edited by newhoggy

Description

update chaps index:

  • increase bounds on ledger core
  • increase bounds on plutus
  • support Plutus V3 in conway ledger era
  • add query field to LocalNodeConnectInfo record. (However, I was reluctant to break the API functions foldBlocks and queryStateForBalancedTx without knowing what I am doing, so I hardcoded the value True for them).

(replaces #23, which was from a fork)

Changelog

- description: |
    Changes:
    - Updated plutus, ledger, and consensus dependency bounds
    - Added support for Plutus V3 in conway
    - Added a `query` field to `LocalNodeConnectInfo`
    - Field added to `LocalNodeConnectInfo`
  # no-changes: the API has not changed
  # compatible: the API has changed but is non-breaking
  # breaking: the API has changed in a breaking way
  compatibility: breaking
  # feature: the change implements a new feature in the API
  # bugfix: the change fixes a bug in the API
  # test: the change fixes modifies tests
  # maintenance: the change involves something other than the API
  type: feature

TODO

  • Is it okay that I have hard-coded a value of True for the query field used by the two public API functions queryStateForBalancedTx and foldBlocks?

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@JaredCorduan JaredCorduan mentioned this pull request May 25, 2023
Closed
11 tasks
@newhoggy newhoggy requested a review from carbolymer as a code owner May 25, 2023 06:00
@JaredCorduan JaredCorduan force-pushed the jc/update-chaps-index branch 2 times, most recently from 260102d to b7dcc46 Compare May 25, 2023 13:03
Jimbo4350
Jimbo4350 reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

cardano-api/internal/Cardano/Api/Convenience/Query.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/LedgerState.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Script.hs

parsePlutusScriptVersion :: Text -> Aeson.Parser AnyPlutusScriptVersion
parsePlutusScriptVersion t =
case t of
"PlutusScriptV1" -> return (AnyPlutusScriptVersion PlutusScriptV1)
"PlutusScriptV2" -> return (AnyPlutusScriptVersion PlutusScriptV2)
_ -> fail "Expected PlutusScriptV1 or PlutusScriptV2"
"PlutusScriptV3" -> return (AnyPlutusScriptVersion PlutusScriptV3)
_ -> fail "Expected PlutusScriptVX, for X = 1, 2, or 3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a mathematician 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least I didn't leave it to the reader to determine the correct values of X 😆 .

@Jimbo4350 Jimbo4350 self-requested a review May 25, 2023 16:41
@JaredCorduan
update chaps index
7c28153 
* increase bounds on ledger core
* increase bounds on plutus
* support Plutus V3 in conway ledger era
@disassembler disassembler added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit 89fd117 May 25, 2023
14 checks passed
newhoggy added a commit that referenced this pull request Mar 11, 2024
@newhoggy
Merge pull request #24 from input-output-hk/newhoggy/simplify-querySt…
142ee0d 
…ateForBalancedTx

Use simplified `queryStateForBalancedTx`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy left review comments

@carbolymer carbolymer carbolymer approved these changes

@disassembler disassembler disassembler approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JaredCorduan @newhoggy @carbolymer @disassembler @Jimbo4350