Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UpdateProposalSupportedInEra with ShelleyToBabbageEra #258

Conversation

newhoggy
Copy link
Collaborator

Changelog

- description: |
    Replace `UpdateproposalSupportedInEra` with `ShelleyToBabbageEra`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

TxUpdateProposal UpdateProposalInBabbageEra
(fromLedgerUpdate sbe p)

ShelleyBasedEraConway -> TxUpdateProposalNone
Copy link
Collaborator Author

@newhoggy newhoggy Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conway is not supported, but our types don't reflect that. This PR encodes this fact in the types and simplifies the code.

@newhoggy newhoggy force-pushed the newhoggy/replace-UpdateProposalSupportedInEra-with-ShelleyToBabbageEra branch from 5c9bf43 to 88d4daa Compare September 26, 2023 04:04
@newhoggy newhoggy added this pull request to the merge queue Sep 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 26, 2023
@newhoggy newhoggy force-pushed the newhoggy/replace-UpdateProposalSupportedInEra-with-ShelleyToBabbageEra branch from 88d4daa to ce4af0a Compare September 26, 2023 04:41
@newhoggy newhoggy added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 26b9f1f Sep 26, 2023
20 checks passed
@newhoggy newhoggy deleted the newhoggy/replace-UpdateProposalSupportedInEra-with-ShelleyToBabbageEra branch September 26, 2023 05:28
@newhoggy newhoggy changed the title Replace UpdateproposalSupportedInEra with ShelleyToBabbageEra Replace UpdateProposalSupportedInEra with ShelleyToBabbageEra Sep 26, 2023
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants