Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate latest ledger and ouroboros-consensus for 8.6 #321

Merged
merged 14 commits into from Oct 27, 2023

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Oct 17, 2023

Changelog

- description: |
    Updated ledger, consensus and typed-protocol packages
    Adapted ProtocolParameters to the new ProtVer >=8 constraint in  in ppuProtocolVersionL
    Replaced  queryCommitteState with new queryCommitteeMembersState
    Improved  costModel generation for tests
    Adapt to new type HKDNoUpdate f ProtVer of cppProtocolVersion
    Export types needed for querying the committee state
    Adjust to type change of proposalProceduresTxBodyL
    Remove invalidBeforeL and invalidHereAfterL defined in ledger
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Release node 8.6

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/ledger-and-consensus-for-8.6 branch from 9b2d3d4 to 001d9c0 Compare October 17, 2023 11:19
@teodanciu teodanciu force-pushed the td/ledger-and-consensus-for-8.6 branch from 001d9c0 to f9a42c7 Compare October 17, 2023 11:33
@teodanciu teodanciu force-pushed the td/ledger-and-consensus-for-8.6 branch 4 times, most recently from 4a7ee97 to 20bc444 Compare October 17, 2023 13:52
@teodanciu teodanciu force-pushed the td/ledger-and-consensus-for-8.6 branch 10 times, most recently from ce1b27e to 289d57e Compare October 19, 2023 11:43
@teodanciu teodanciu changed the title Integrate latest ledger and ouroboros-consensus for 8.6.0-pre - SRP Integrate latest ledger and ouroboros-consensus for 8.6.0-pre - SRP (based on cardano-api-8.26.0.0) Oct 19, 2023
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the changes to PParamsUpdate and withProtVer but the rest looks good to me 👍

@teodanciu teodanciu changed the title Integrate latest ledger and ouroboros-consensus for 8.6.0-pre - SRP (based on cardano-api-8.26.0.0) Integrate latest ledger and ouroboros-consensus for 8.6.0- SRP (based on cardano-api-8.26.0.0) Oct 19, 2023
@teodanciu teodanciu force-pushed the td/ledger-and-consensus-for-8.6 branch 4 times, most recently from 9e1f564 to 83a0652 Compare October 19, 2023 17:46
@teodanciu teodanciu changed the title Integrate latest ledger and ouroboros-consensus for 8.6.0- SRP (based on cardano-api-8.26.0.0) Integrate latest ledger and ouroboros-consensus for 8.6.0- SRP (based on cardano-api-8.27.0.0) Oct 19, 2023
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

cardano-api/internal/Cardano/Api/Certificate.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Orphans.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Query.hs Show resolved Hide resolved
@teodanciu teodanciu force-pushed the td/ledger-and-consensus-for-8.6 branch from 83a0652 to 2b8800e Compare October 19, 2023 18:59
@teodanciu teodanciu force-pushed the td/ledger-and-consensus-for-8.6 branch 2 times, most recently from 31f0f31 to 8fd4dad Compare October 26, 2023 22:20
@teodanciu teodanciu force-pushed the td/ledger-and-consensus-for-8.6 branch from 8fd4dad to 2478f54 Compare October 26, 2023 22:55
@newhoggy newhoggy added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit cd2fd28 Oct 27, 2023
20 checks passed
@newhoggy newhoggy deleted the td/ledger-and-consensus-for-8.6 branch October 27, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants