Delete unnecessary calls to shelleyBasedEraConstraints

[newhoggy]

Changelog

- description: |
    Delete unnecessary calls to `shelleyBasedEraConstraints`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• The change log section in the PR description has been filled in
• New tests are added if needed and existing tests are updated. These may include:
  • golden tests
  • property tests
  • round trip tests
  • integration tests
    See Running tests for more details
• The version bounds in .cabal files are updated
• CI passes. See note on CI. The following CI checks are required:
  • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
  • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
• Self-reviewed the diff

[carlhammann]

@newhoggy is there an easy criterion to remember the ShelleyBasedEraConstraints, or does one just know them eventually? I wonder how many PRs like this are still possible... Shame that -Wredundant-constraints can't pick up on this.

[newhoggy]

@newhoggy is there an easy criterion to remember the ShelleyBasedEraConstraints, or does one just know them eventually? I wonder how many PRs like this are still possible... Shame that -Wredundant-constraints can't pick up on this.

There's an API design I've been thinking of that would let us drop things like shelleyBasedEraConstraints except for a thin layer around the ledger, at that point those function could even be removed from the export list.