Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for simple scripts in Conway #344

Merged
merged 1 commit into from Oct 25, 2023

Conversation

carlhammann
Copy link
Contributor

Changelog

- description: |
   Add support for simple scripts in Conway
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This closes #337. As explained there, Conway era should support all script versions from earlier eras. As the similar PR #323, I think all that went wrong was someone forgetting a clause.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 5b5d63f Oct 25, 2023
22 checks passed
@Jimbo4350 Jimbo4350 deleted the ch/support-simple-scripts-in-coway branch October 25, 2023 14:21
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…mes-update-committee

Rename create-new-committee into update-committee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Conway era does not support Simple Scripts
2 participants