Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a query for vote delegatees #367

Merged
merged 1 commit into from Nov 21, 2023
Merged

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Nov 13, 2023

Changelog

- description: |
    Add `QueryStakeVoteDelegatees` to return the vote delegatee associated to a stake credential
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR implements a query that is needed to solve issue 423 of cardano-api. It used to depend on cherry-picked commits of ouroboros-consensus, but with #359 merged, it doesn't any more.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carlhammann carlhammann force-pushed the ch/vote-delegatee-query branch 4 times, most recently from e9b768f to dedb3d6 Compare November 20, 2023 13:47
@carlhammann carlhammann added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit b0b916d Nov 21, 2023
21 checks passed
@carlhammann carlhammann deleted the ch/vote-delegatee-query branch November 21, 2023 07:53
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants