Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new module Test.Gen.Cardano.Api.ProtocolParameters #369

Merged
merged 2 commits into from Nov 14, 2023

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Nov 14, 2023

Changelog

- description: |
    Update and export `Test.Gen.Cardano.Api.ProtocolParameters`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

On #352, I forgot to export the new module I added. Also, the EraBasedProtocolParametersUpdate has changed since then, necessitating new generators. Since the module wasn't exported, CI didn't catch that mismatch...

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carlhammann carlhammann changed the title Leftover from #352: forgot to expose new module Leftover from #352: forgot to expose new module Test.Gen.Cardano.Api.ProtocolParameters Nov 14, 2023
@carlhammann carlhammann added this pull request to the merge queue Nov 14, 2023
@newhoggy newhoggy changed the title Leftover from #352: forgot to expose new module Test.Gen.Cardano.Api.ProtocolParameters Expose new module Test.Gen.Cardano.Api.ProtocolParameters Nov 14, 2023
Merged via the queue into main with commit 004ade6 Nov 14, 2023
27 checks passed
@carlhammann carlhammann deleted the ch/expose-protocol-parameters-generators branch November 14, 2023 13:25
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…arameters-fix

Update Protocol Parameters Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants