Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor prettyprinter fixes #375

Merged
merged 2 commits into from Nov 17, 2023
Merged

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Nov 17, 2023

Changelog

- description: |
    `Error` instance for `FileError` instead of `Pretty`
    Make `prettyToText` return strict `Text` and add `prettyToLazyText`
    Export `Doc`
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@@ -1,8 +1,10 @@
module Cardano.Api.Pretty
( Ann
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Ann a default Doc annotation for api, or what's its purpose? Can you add a short comment explaining what's Ann?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It is behind a type alias so we can change the implementation if needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment.

@newhoggy newhoggy force-pushed the newhoggy/minor-prettyprinter-fixes branch from 550e38c to 926215b Compare November 17, 2023 10:19
@newhoggy newhoggy added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit b3a7387 Nov 17, 2023
20 checks passed
@newhoggy newhoggy deleted the newhoggy/minor-prettyprinter-fixes branch November 17, 2023 10:53
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
Make `stake-address-info` query also return deposit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants