Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to ReexposeLedger #420

Merged
merged 6 commits into from Feb 13, 2024
Merged

Conversation

felix-lipski
Copy link
Contributor

@felix-lipski felix-lipski commented Jan 8, 2024

Changelog

- description: |
    add types for reexport
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Issue

This needs to be merged in order to merge this CLI PR

How to trust this PR

N/A

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@felix-lipski felix-lipski changed the title remove cardano ledger imports add some types to Reexported ledger Jan 8, 2024
@felix-lipski felix-lipski changed the title add some types to Reexported ledger Add types to ReexposeLedger Jan 8, 2024
@felix-lipski felix-lipski force-pushed the felix-lipski/remove-cardano-ledger-imports branch 3 times, most recently from f7f840d to c7d21f1 Compare January 8, 2024 15:23
@felix-lipski felix-lipski marked this pull request as ready for review January 8, 2024 15:24
@felix-lipski felix-lipski force-pushed the felix-lipski/remove-cardano-ledger-imports branch from c7d21f1 to 4092fd4 Compare January 8, 2024 15:33
@palas palas self-assigned this Feb 12, 2024
@palas palas marked this pull request as draft February 12, 2024 20:53
@palas palas marked this pull request as ready for review February 13, 2024 02:59
@palas palas added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit f590906 Feb 13, 2024
22 checks passed
@palas palas deleted the felix-lipski/remove-cardano-ledger-imports branch February 13, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants