-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow checkLedgerStateCondition check to run in IO #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
force-pushed
the
mgalazyn/feature/allow-io-checkledgerstate
branch
from
February 13, 2024 20:58
cf2d476
to
de1cd40
Compare
@carbolymer> can you show how it affects callers? |
carbolymer
force-pushed
the
mgalazyn/feature/allow-io-checkledgerstate
branch
from
February 15, 2024 14:51
de1cd40
to
c11ef14
Compare
carbolymer
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
CarlosLopezDeLara and
disassembler
as code owners
February 16, 2024 14:27
carbolymer
commented
Feb 16, 2024
carbolymer
force-pushed
the
mgalazyn/feature/allow-io-checkledgerstate
branch
from
February 16, 2024 14:51
c11ef14
to
470ed9c
Compare
Jimbo4350
reviewed
Feb 16, 2024
Jimbo4350
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Have you integrated this against cardano-node with an SRP to check tests still run?
Jimbo4350
approved these changes
Feb 19, 2024
Jimbo4350
reviewed
Feb 19, 2024
carbolymer
force-pushed
the
mgalazyn/feature/allow-io-checkledgerstate
branch
2 times, most recently
from
February 20, 2024 16:36
0b62cdf
to
5fab752
Compare
carbolymer
force-pushed
the
mgalazyn/feature/allow-io-checkledgerstate
branch
from
February 20, 2024 16:42
5fab752
to
ded8d78
Compare
carbolymer
force-pushed
the
mgalazyn/feature/allow-io-checkledgerstate
branch
from
February 21, 2024 07:03
ded8d78
to
abfef20
Compare
3 tasks
newhoggy
pushed a commit
that referenced
this pull request
Mar 11, 2024
Add golden tests for `--drep-key-hash` in `governance drep`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR allows
checkLedgerStateCondition
check function to run IO actions.This enables more complex test logic, as well as real-time export of the new epoch state.
cardano-testnet
was altered to support this change here:Checklist