Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checkLedgerStateCondition check to run in IO #453

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 13, 2024

Changelog

- description: |
    Allow `checkLedgerStateCondition` check to run in IO. Rename to `foldEpochState`.
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR allows checkLedgerStateCondition check function to run IO actions.
This enables more complex test logic, as well as real-time export of the new epoch state.
cardano-testnet was altered to support this change here:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/allow-io-checkledgerstate branch from cf2d476 to de1cd40 Compare February 13, 2024 20:58
@smelc
Copy link
Contributor

smelc commented Feb 14, 2024

@carbolymer> can you show how it affects callers?

@carbolymer
Copy link
Contributor Author

@smelc https://github.com/IntersectMBO/cardano-node/pull/5662/files

@carbolymer carbolymer force-pushed the mgalazyn/feature/allow-io-checkledgerstate branch from de1cd40 to c11ef14 Compare February 15, 2024 14:51
@carbolymer carbolymer marked this pull request as ready for review February 16, 2024 14:27
@carbolymer carbolymer force-pushed the mgalazyn/feature/allow-io-checkledgerstate branch from c11ef14 to 470ed9c Compare February 16, 2024 14:51
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Have you integrated this against cardano-node with an SRP to check tests still run?

@carbolymer
Copy link
Contributor Author

@Jimbo4350 Jimbo4350 self-requested a review February 19, 2024 14:14
@carbolymer carbolymer force-pushed the mgalazyn/feature/allow-io-checkledgerstate branch 2 times, most recently from 0b62cdf to 5fab752 Compare February 20, 2024 16:36
@carbolymer carbolymer force-pushed the mgalazyn/feature/allow-io-checkledgerstate branch from 5fab752 to ded8d78 Compare February 20, 2024 16:42
@carbolymer carbolymer force-pushed the mgalazyn/feature/allow-io-checkledgerstate branch from ded8d78 to abfef20 Compare February 21, 2024 07:03
@carbolymer carbolymer added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit f5fadfa Feb 21, 2024
21 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/allow-io-checkledgerstate branch February 21, 2024 07:32
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
Add golden tests for `--drep-key-hash` in `governance drep`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants