Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify queryStateForBalancedTx #47

Merged
merged 8 commits into from Jun 15, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jun 14, 2023

Description

Contextual PR: Contextual PR: input-output-hk/fusion-flamingo#9

Changelog

- description: |
    Simplify `queryStateForBalancedTx` such that:
    * It no longer invokes `executeQueryCardanoMode` `queryNodeLocalState, allowing it to run over a single connection
    * It no longer takes `socketPath` and `networkId` parameters
  compatibility: breaking
  type: feature

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/simplify-queryStateForBalancedTx branch from 2ce1c94 to 69a49ec Compare June 14, 2023 21:44
@newhoggy newhoggy force-pushed the newhoggy/simplify-queryStateForBalancedTx branch from 69a49ec to 617ea7c Compare June 15, 2023 00:33
@newhoggy newhoggy added this pull request to the merge queue Jun 15, 2023
Merged via the queue into main with commit 42552e6 Jun 15, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants