Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for script-based CC members #489

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Mar 18, 2024

Changelog

- description: |
    Add support for script-based CC members
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Enables all credentials (ScriptHashObj & KeyHashObj) to be used in updating committee action.

A prerequisite for:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Keys/Shelley.hs Outdated Show resolved Hide resolved
=> StdGen
-> AsType keyrole
-> IO (SigningKey keyrole, StdGen)
-> m (SigningKey keyrole, StdGen)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@carbolymer carbolymer force-pushed the mgalazyn/feature/script-based-cc-members branch from c36f6be to 8b13a9a Compare March 19, 2024 11:59
@carbolymer carbolymer added this pull request to the merge queue Mar 19, 2024
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Mar 19, 2024
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-based-cc-members branch from 8b13a9a to 93e04ef Compare March 19, 2024 16:57
Co-authored-by: Clément Hurlin <smelc@users.noreply.github.com>
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-based-cc-members branch from 93e04ef to 988a291 Compare March 19, 2024 16:59
@carbolymer carbolymer added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 8ff4d50 Mar 19, 2024
23 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/script-based-cc-members branch March 19, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants