Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update estimateBalancedTxBody to account for required deposits #527

Merged
merged 1 commit into from
May 3, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented May 2, 2024

Changelog

Relevant part of the spec:
Relevant part of the spec

- description: |
    Update estimateBalancedTxBody to account for required deposits due to 
    governance proposals and stake registration certificates
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

… governance

proposals and stake registration certificates
@Jimbo4350 Jimbo4350 force-pushed the jordan/include-deposits-estimateBalancedTxBody branch from 98883f7 to 6e27735 Compare May 2, 2024 12:29
@Jimbo4350 Jimbo4350 merged commit 21dd76e into main May 3, 2024
16 of 28 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/include-deposits-estimateBalancedTxBody branch May 3, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants