Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-output-hk/cardano-node#5222 Remove of reading of ApplicationName and ApplicationVersion from node config and replace with hardcoded values #8

Merged
merged 1 commit into from May 24, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 22, 2023

Description

This is a part of IntersectMBO/cardano-node#5222 . Removes reading of ApplicationName and ApplicationVersion from FromJSON instances.

Changelog

- description: |
    Remove support for reading `ApplicationName` and `ApplicationVersion` from node configuration and replace with hardcoded values.
  compatibility: breaking
  type: feature

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/remove-unused-cfg-params branch 2 times, most recently from 90d8589 to 8bb6430 Compare May 22, 2023 16:55
@carbolymer carbolymer marked this pull request as ready for review May 22, 2023 17:00
@carbolymer carbolymer force-pushed the mgalazyn/remove-unused-cfg-params branch from 8bb6430 to d0bc0c2 Compare May 22, 2023 17:09
@@ -198,3 +202,12 @@ makeByronVote nId sKey (ByronUpdateProposal proposal) yesOrNo =

toByronLedgertoByronVote :: ByronVote -> Mempool.GenTx ByronBlock
toByronLedgertoByronVote (ByronVote vote) = Mempool.ByronUpdateVote (recoverVoteId vote) vote

applicationName :: Update.ApplicationName
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave a comment here saying these have no functional impact in the Shelley eras onwards and therefore we opt to hard code them because of this

@carbolymer carbolymer force-pushed the mgalazyn/remove-unused-cfg-params branch from d0bc0c2 to 040b629 Compare May 24, 2023 14:24
@carbolymer carbolymer enabled auto-merge May 24, 2023 14:24
@carbolymer carbolymer added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit 2d2c37b May 24, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants