Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting procedure and proposal procedure updates #85

Merged
merged 3 commits into from Jun 30, 2023

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jun 29, 2023

Changelog

- description: |
    Update VotingCredential to be parameterized on cardano-api's era type
  compatibility: breaking
  type: feature

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 force-pushed the jordan/voting-procedure-governance-procedure-updates branch from abc4226 to 3be5fff Compare June 30, 2023 13:53
@Jimbo4350 Jimbo4350 marked this pull request as ready for review June 30, 2023 14:17
@Jimbo4350 Jimbo4350 force-pushed the jordan/voting-procedure-governance-procedure-updates branch from 3be5fff to e9b4c73 Compare June 30, 2023 14:19
@Jimbo4350 Jimbo4350 force-pushed the jordan/voting-procedure-governance-procedure-updates branch from e9b4c73 to a71def7 Compare June 30, 2023 14:26
@Jimbo4350
Copy link
Contributor Author

don't merge yet

@Jimbo4350 Jimbo4350 force-pushed the jordan/voting-procedure-governance-procedure-updates branch 5 times, most recently from dcb453a to 4d086ba Compare June 30, 2023 15:58
@Jimbo4350 Jimbo4350 force-pushed the jordan/voting-procedure-governance-procedure-updates branch from 4d086ba to 399eb8f Compare June 30, 2023 16:23
@Jimbo4350 Jimbo4350 enabled auto-merge June 30, 2023 16:23
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit c4c12b0 Jun 30, 2023
16 of 18 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/voting-procedure-governance-procedure-updates branch June 30, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants