Add a redundant check for future proofing changes to secp256k1 library

IntersectMBO · Aug 8, 2022 · 8b624d6 · 8b624d6
1 parent 6571b52
commit 8b624d6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/cardano-crypto-class/src/Cardano/Crypto/DSIGN/EcdsaSecp256k1.hs b/cardano-crypto-class/src/Cardano/Crypto/DSIGN/EcdsaSecp256k1.hs
@@ -222,10 +222,14 @@ instance DSIGNAlgorithm EcdsaSecp256k1DSIGN where
           alloca $ \(lenPtr :: Ptr CSize) -> do
             poke lenPtr len
             withForeignPtr secpCtxPtr $ \ctx -> do
-              void $ secpEcPubkeySerialize ctx dstp lenPtr psp secpEcCompressed
+              ret <- secpEcPubkeySerialize ctx dstp lenPtr psp secpEcCompressed
               writtenLen <- peek lenPtr
               unless (writtenLen == len)
                      (error "rawSerializeVerKeyDSIGN: Did not write correct length for VerKeyDSIGN EcdsaSecp256k1DSIGN")
+              -- This should never happen, since `secpEcPubkeySerialize` in the current
+              -- version of `secp256k1` library always returns 1:
+              unless (ret == 1)
+                     (error "rawSerializeVerKeyDSIGN: Failed for unknown reason")
     rawSerialiseSignKeyDSIGN (SignKeyEcdsaSecp256k1 psb) = psbToByteString psb
     {-# NOINLINE rawDeserialiseSigDSIGN #-}
     rawDeserialiseSigDSIGN bs =