Add conversion Praos to PraosBatchCompat #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdammers
requested changes
Nov 28, 2022
iquerejeta
force-pushed
the
update-vrf
branch
from
6d63bea
to
7355eeb
Compare
iquerejeta
force-pushed
the
iquerejeta/type-conversions
branch
from
cb0dff2
to
146ecd0
Compare
iquerejeta
force-pushed
the
update-vrf
branch
from
9d93fd6
to
1479014
Compare
iquerejeta
force-pushed
the
iquerejeta/type-conversions
branch
from
146ecd0
to
b41a5fa
Compare
iquerejeta
force-pushed
the
update-vrf
branch
3 times, most recently
from
e62d4c1
to
73a9eb4
Compare
iquerejeta
force-pushed
the
update-vrf
branch
2 times, most recently
from
4c5bfde
to
30f69ed
Compare
iquerejeta
force-pushed
the
iquerejeta/type-conversions
branch
2 times, most recently
from
876563e
to
696b301
Compare
lehins
approved these changes
Jan 30, 2023
iquerejeta
force-pushed
the
iquerejeta/type-conversions
branch
from
f2166d8
to
9ad1983
Compare
tdammers
approved these changes
Feb 2, 2023
tdammers
requested changes
Feb 6, 2023
iquerejeta
force-pushed
the
iquerejeta/type-conversions
branch
from
dbd0e36
to
d264b45
Compare
tdammers
approved these changes
Feb 7, 2023
We also disambiguate between VerKey and SignKey conversion errors. Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
iquerejeta
force-pushed
the
iquerejeta/type-conversions
branch
from
d264b45
to
c4b1790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the new
BatchCompatVRF types are compatible with the existingPraostypes. In this PR we create conversion functions, to allow for a smooth transition between the compatible types.In particular, we create the following conversion functions:
skToBatchCompat :: SignKeyVRF PraosVRF -> SignKeyVRF BC.PraosBatchCompatVRFvkToBatchCompat :: VerKeyVRF PraosVRF -> VerKeyVRF BC.PraosBatchCompatVRFoutputToBatchCompat :: OutputVRF PraosVRF -> OutputVRF BC.PraosBatchCompatVRFWe include tests to guarantee the compatibility of these converted types.
This closes #345