Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-up cardano-cli <era> governance commands #313

Closed
3 tasks done
CarlosLopezDeLara opened this issue Sep 27, 2023 · 4 comments · Fixed by #368
Closed
3 tasks done

clean-up cardano-cli <era> governance commands #313

CarlosLopezDeLara opened this issue Sep 27, 2023 · 4 comments · Fixed by #368

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Sep 27, 2023

What to do

The command cardano-cli <era> governance is still a bit off, ideally:

eras Shelley - Alonzo should show these options

Usage: cardano-cli <era shelley to alonzo> governance
                                ( create-mir-certificate
                                | create-genesis-key-delegation-certificate
                                | create-update-proposal
                                )

Babbage should have

Usage: cardano-cli babbage governance
                                ( create-mir-certificate
                                | create-genesis-key-delegation-certificate
                                | create-update-proposal
                                | create-poll
                                | answer-poll
                                | verify-poll
                                )

Conway should have

Usage: cardano-cli conway governance (query | action | committee | drep | vote)

<<<--- Note that query should be relocated, see #312

How to do - roadmap

@smelc
Copy link
Contributor

smelc commented Oct 3, 2023

@CarlosLopezDeLara> so create-poll, answer-poll, and verify-poll are babbage specific right?

Asking because it implies a number of moves around in #322 (the test of the *-poll commands are in shelley right now).

@smelc
Copy link
Contributor

smelc commented Oct 11, 2023

As of eb0e52b, the governance entry for shelley to alonzo is as follows:

for era in shelley allegra mary alonzo
do
cabal run cardano-cli -- $era governance
done
Usage: cardano-cli shelley governance (create-mir-certificate | action)

  Governance commands.

Available options:
  -h,--help                Show this help text

Available commands:
  create-mir-certificate   Create an MIR (Move Instantaneous Rewards)
                           certificate
  action                   Governance action commands.
Usage: cardano-cli allegra governance (create-mir-certificate | action)

  Governance commands.

Available options:
  -h,--help                Show this help text

Available commands:
  create-mir-certificate   Create an MIR (Move Instantaneous Rewards)
                           certificate
  action                   Governance action commands.
Usage: cardano-cli mary governance (create-mir-certificate | action)

  Governance commands.

Available options:
  -h,--help                Show this help text

Available commands:
  create-mir-certificate   Create an MIR (Move Instantaneous Rewards)
                           certificate
  action                   Governance action commands.
Usage: cardano-cli alonzo governance (create-mir-certificate | action)

  Governance commands.

Available options:
  -h,--help                Show this help text

Available commands:
  create-mir-certificate   Create an MIR (Move Instantaneous Rewards)
                           certificate
  action                   Governance action commands.

@smelc
Copy link
Contributor

smelc commented Oct 11, 2023

The previous comment shows that eras from shelley to alonzo miss the create-genesis-key-delegation-certificate action.

@smelc
Copy link
Contributor

smelc commented Oct 11, 2023

As of eb0e52b, the create-genesis-key-delegation-certificate command occurs in two places:

Usage: cardano-cli governance 
                                ( create-mir-certificate
                                | create-genesis-key-delegation-certificate
                                | create-update-proposal
                                | create-poll
                                | answer-poll
                                | verify-poll
                                )

...

Usage: cardano-cli governance create-genesis-key-delegation-certificate 
                                                                          [ --shelley-era
                                                                          | --allegra-era
                                                                          | --mary-era
                                                                          | --alonzo-era
                                                                          | --babbage-era
                                                                          | --conway-era
                                                                          ]
                                                                          ( --genesis-verification-key STRING
                                                                          | --genesis-verification-key-file FILE
                                                                          | --genesis-verification-key-hash STRING
                                                                          )
                                                                          ( --genesis-delegate-verification-key STRING
                                                                          | --genesis-delegate-verification-key-file FILE
                                                                          | --genesis-delegate-verification-key-hash STRING
                                                                          )
                                                                          ( --vrf-verification-key STRING
                                                                          | --vrf-verification-key-file FILE
                                                                          | --vrf-verification-key-hash STRING
                                                                          )
                                                                          --out-file FILE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants