Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query leadership-schedule: add --output-[json,text] flag to control format of the output #649

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Mar 14, 2024

Changelog

- description: |
    query leadership: add --output-[json,text] flag to control format of the output. Previous behavior is preserved (write text to stdout, write json to file)
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

  • I tested this PR manually with this test from cardano-node. I tested all new behaviors.
  • I checked manually that the historical behavior was preserved.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc marked this pull request as ready for review March 14, 2024 16:00
@smelc smelc added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit bd22b2e Mar 15, 2024
18 checks passed
@smelc smelc deleted the smelc/query-leadership-control-output-format branch March 15, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants