Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands' descriptions referencing old 'governance hash' command #821

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 4, 2024

Changelog

- description: |
    Fix commands' descriptions referencing old 'governance hash' command
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

There were references to old syntax of conway governance hash command in the help texts.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor

smelc commented Jul 4, 2024

I swear I had grepped for conway governance hash but somehow either lost my changes or pebkac 🙃

Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carbolymer carbolymer disabled auto-merge July 10, 2024 12:18
@carbolymer carbolymer merged commit 1c70add into main Jul 10, 2024
15 of 16 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/fix-cli-descriptions-referencing-hash-commands branch July 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants