Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix production of Linux static binaries in release workflow #839

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jul 16, 2024

Changelog

- description: |
    Fix production of static binaries in releases (by adapting to changes in Hydra's job names)
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

This PR's new workflow was triggered manually as follows:

gh workflow run .github/workflows/release-upload.yml -r $(git branch --show-current) -f target_tag=e5bb0adc4d43f1470619f7fcf5a4831f20910100

This makes this PR's workflow download the binaries from commit e5bb0ad (which is on main). The workflow succeeded as visible here: https://github.com/IntersectMBO/cardano-cli/actions/runs/9959206931

Then you can download the artifact:

image

And run file on it:

05:13:57 HOME/Downloads → file ./cardano-cli-x86_64-linux
./cardano-cli-x86_64-linux: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped

@smelc smelc force-pushed the smelc/fix-static-binaries-releasing branch from 93f5a32 to de24c5b Compare July 16, 2024 15:01
@smelc smelc marked this pull request as ready for review July 16, 2024 15:15
@smelc smelc requested review from a team as code owners July 16, 2024 15:15
@smelc smelc changed the title Fix production of static binaries in releases Fix production of Linux static binaries in release workflow Jul 16, 2024
@smelc smelc added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit d4c08cf Jul 16, 2024
26 checks passed
@smelc smelc deleted the smelc/fix-static-binaries-releasing branch July 16, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore production of statically linked binaries
2 participants