Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Check that remainingFee correctly detects balanced coin selections. #36

Closed
wants to merge 2 commits into from
Closed

WIP: Check that remainingFee correctly detects balanced coin selections. #36

wants to merge 2 commits into from

Conversation

jonathanknowles
Copy link
Contributor

@jonathanknowles jonathanknowles commented Apr 8, 2020 •
edited
Loading

Work in progress.

The property added by this PR currently fails, as it triggers the run-time error case within remainingFee.

@jonathanknowles jonathanknowles self-assigned this Apr 8, 2020
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/remaining-fee-test-preparation branch 2 times, most recently from 32d888c to f03e38a Compare April 9, 2020 10:24
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/test-remaining-fee branch from 5c0f805 to ab6a15c Compare April 9, 2020 10:30
@jonathanknowles jonathanknowles mentioned this pull request Apr 9, 2020
Merged
4 tasks
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/test-remaining-fee branch from ab6a15c to 1c5299d Compare April 9, 2020 10:46
@jonathanknowles jonathanknowles changed the base branch from jonathanknowles/remaining-fee-test-preparation to master April 9, 2020 10:46
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/test-remaining-fee branch from 1c5299d to fa10249 Compare April 15, 2020 06:10
@jonathanknowles jonathanknowles mentioned this pull request Apr 23, 2020
Closed
@jonathanknowles
Copy link
Contributor Author

Closing this for now, as the work has been superseded by #62.

@jonathanknowles jonathanknowles deleted the jonathanknowles/test-remaining-fee branch April 27, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Awaiting requested review from Anviking Anviking will be requested when the pull request is marked ready for review Anviking is a code owner

@HeinrichApfelmus HeinrichApfelmus Awaiting requested review from HeinrichApfelmus HeinrichApfelmus will be requested when the pull request is marked ready for review HeinrichApfelmus is a code owner

@paweljakubas paweljakubas Awaiting requested review from paweljakubas paweljakubas will be requested when the pull request is marked ready for review paweljakubas is a code owner

@Unisay Unisay Awaiting requested review from Unisay Unisay will be requested when the pull request is marked ready for review Unisay is a code owner

Assignees

@jonathanknowles jonathanknowles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonathanknowles