Disable Automatic Algorithm Fallback #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#30
Summary
The
cardano-wallet
library currently performs automatic fallback fromRandom-Improve
toLargest-First
if the former algorithm is unable to compute a valid coin selection.However, this automatic fallback might not be appropriate for all users of the coin selection library.
This PR:
Random-Improve
.Random-Improve
can no longer rely on the error handling provided byLargest-First
.The error handling is already tested by our existing test suite.