Still getting missing foreign key exception of pool metadata tables

[erikd]

While working on another aspect I was getting an error "aggregate functions are not allowed in WHERE" which was then followed (after a roll back to the start of the epoch) by:

DbInsertException "PoolOfflineFetchError"
  ( SqlError
    { sqlState = "23503"
    , sqlExecStatus = FatalError
    , sqlErrorMsg = "insert or update on table \"pool_offline_fetch_error\" violates foreign key \
                                       \constraint \"pool_offline_fetch_error_pmr_id_fkey\""
    , sqlErrorDetail = "Key (pmr_id)=(1312) is not present in table \"pool_metadata_ref\"."
    , sqlErrorHint = ""
    }
  ) 

I have checked that commit d658f38 is present in the branch I am working on.

[erikd]

😢 Turns out the insertOfflineResults function had:

    insert :: (MonadBaseControl IO m, MonadIO m) => FetchResult -> ReaderT SqlBackend m ()
    insert fr =
      case fr of
        ResultMetadata md -> void $ DB.insertPoolOfflineData md
        ResultError fe -> void $ DB.insertPoolOfflineFetchError fe

Probably as the result of a bad git merge.

That should have been using DB.insertCheckPoolOfflineData and DB.insertCheckPoolOfflineFetchError.

To reiterate:

• The test for this was correctly using the checked versions of these functions
• The actual real code was using the old unckecked versions of these functions

The solution is to permanently remove the unchecked versions of those functions

[erikd]

This affects both master and the latest 11.0.3 release 😢

[erikd]

This will be in release 11.0.4 .