Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conway fixes #1573

Merged
merged 7 commits into from
Dec 9, 2023
Merged

conway fixes #1573

merged 7 commits into from
Dec 9, 2023

Conversation

kderme
Copy link
Contributor

@kderme kderme commented Dec 7, 2023

Description

Related to #1560 #1553

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@kderme kderme marked this pull request as ready for review December 9, 2023 13:49
@kderme kderme requested a review from a team as a code owner December 9, 2023 13:49
@kderme kderme merged commit 2ef303c into master Dec 9, 2023
18 of 23 checks passed
@iohk-bors iohk-bors bot deleted the kderme/conway-fixes branch December 9, 2023 13:50
@kderme kderme changed the title Kderme/conway fixes conway fixes Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants