optimizations #1607
Merged
optimizations #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderme
commented
Jan 18, 2024
schema/migration-2-0035-20240108.sql
Outdated
| BEGIN | ||
| SELECT stage_two + 1 INTO next_version FROM schema_version ; | ||
| IF next_version = 35 THEN | ||
| EXECUTE 'alter domain addr29type drop constraint addr29type_check' ; |
There was a problem hiding this comment.
When we create these domains
CREATE DOMAIN addr29type AS bytea CHECK (octet_length (VALUE) = 29);
we don't give any name to the constraint. addr29type_check is the name that postgres gives by default.
kderme
commented
Jan 18, 2024
schema/migration-2-0038-20240117.sql
Outdated
| EXECUTE 'ALTER TABLE "instant_reward" ALTER COLUMN "amount" SET NOT NULL' ; | ||
| EXECUTE 'ALTER TABLE "instant_reward" ALTER COLUMN "spendable_epoch" SET NOT NULL' ; | ||
| EXECUTE 'ALTER TABLE "instant_reward" DROP COLUMN "earned_epoch"' ; | ||
| EXECUTE 'ALTER TABLE "instant_reward" ADD COLUMN "earned_epoch" bigint NOT NULL GENERATED ALWAYS AS ((CASE WHEN spendable_epoch >= 1 then spendable_epoch-1 else 0 end)) STORED' ; |
There was a problem hiding this comment.
There is no way to ALTER an existing column to add a GENERATED ALWAYS AS clause. This clause can only be added to a new column. So we drop the old one and add it here. I've checked on a new snapshot that the GENERATED ALWAYS AS rule is always followed even if it didn't exist before. Similarly for reward table.
kderme
commented
Jan 18, 2024
kderme
force-pushed
the
kderme/optimizations
branch
from
b321982
to
df2b608
Compare
Cmdv
reviewed
Jan 22, 2024
sgillespie
reviewed
Jan 24, 2024
sgillespie
reviewed
Jan 24, 2024
sgillespie
previously approved these changes
Jan 24, 2024
|
The hlint check seems to be failing |
kderme
force-pushed
the
kderme/optimizations
branch
from
ce8b581
to
c3853bc
Compare
kderme
force-pushed
the
kderme/optimizations
branch
2 times, most recently
from
950110c
to
f85980b
Compare
Move MIR to a separate table Use "generated always as" for earned_epoch Remove primary keys
Since instant rewards no longer cause a uniqueness issue
kderme
force-pushed
the
kderme/optimizations
branch
2 times, most recently
from
66bc886
to
9bb7ed3
Compare
kderme
force-pushed
the
kderme/optimizations
branch
from
9bb7ed3
to
d5e5e13
Compare
kderme
force-pushed
the
kderme/optimizations
branch
from
d5e5e13
to
f58aab6
Compare
Cmdv
approved these changes
Feb 2, 2024
| @@ -197,11 +197,11 @@ insertShelleyBlock syncEnv shouldLog withinTwoMins withinHalfHour blk details is | |||
|
|
|||
| insertStakeSlice syncEnv $ apStakeSlice applyResult | |||
|
|
|||
| when (ioGov iopts) | |||
| when (ioGov iopts && (withinHalfHour || unBlockNo (Generic.blkBlockNo blk) `mod` 10000 == 0)) | |||
There was a problem hiding this comment.
(withinHalfHour || unBlockNo (Generic.blkBlockNo blk) mod 10000 == 0) could probably sit in the where clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1589, #1582, #1584, #1606
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
The reward migration works on upgrade
The tx_out migation is WIP