db-sync: Reject TxMetadata objects containing NUL characters #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/unicode-txmeta
branch
from
7af2c20
to
3276d8d
Compare
TxMetadata is stored as JSON and that JSON is stored in a 'jsonb' column in PostgreSQL. However, there are limitations to that Postgres 'jsonb' data type. Specifically, it cannot contain Uniciode NUL characters. This temporary fix simply drops TxMetadata JSON objects that would otherwise be rejected by Postgres. Hopefully a better solution will be will be dreamt up and implemented later. Temporary workaround fix for: #297
erikd
force-pushed
the
erikd/unicode-txmeta
branch
from
3276d8d
to
c7ac532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.