Fix maintenance of ledger state #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly for debugging. When this aborts the program, it can leave the database in a werid state.
erikd
force-pushed
the
erikd/new-epoch-failure
branch
from
73358cd
to
66f8705
Compare
Maintenance of ledger state uses code in the consensus packages as a library. * There are two versions of a function to apply a block to a ledger state; a slow one that does full checking and fast one that does fewer checks. * Since db-sync is getting blocks that have already been validated by the node, it seemed sensible to use the fast version. * I had been told that the checks in the fast version included checking that the block's previous hash matches the value of the head hash in the ledger state, but this hash check was not being done. The previous lack of hash checking means the problem was not detected until the start of the next epoch.
erikd
force-pushed
the
erikd/new-epoch-failure
branch
from
66f8705
to
e9932e3
Compare
When blocks and rollback notifications arrive via the chainsync protocol, they are put in a queue and then a separate thread reads from the queue and operates on the DB. When ledger-state management was added, code to apply a block to a ledger state was added at the read end of the queue, but the rollback handling was incorrectly added at the write end of the queue. The solution to the problem is trivial, move the ledger state rollback handling from the write end of the queue to the read end. Closes: https://github.com/input-output-hk/cardano-db-sync/issue/398
erikd
force-pushed
the
erikd/new-epoch-failure
branch
from
e9932e3
to
671f38f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.