-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Migration for efficient rollback #414
Conversation
cabal.project
Outdated
type: git | ||
location: https://github.com/kderme/persistent | ||
tag: 2d02c002761ba0ed05ce95aeef1dfc7bd3caa073 | ||
--sha256: 0jl6ph2cgrl3n2f6j7ff9gqm0scz2dwxq5vs1q1ijxlli37zfzsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, but I wonder if it might be more sensible to wait until these are formally released.
2fbcb6d
to
a098510
Compare
The second bug is discussed here and a fix is proposed. The fix seems to work at least for our case, so this pr is ready to test now. My manual tests show that slot rollback works fine.
Yes my fixes will probably change by the time they're merged. |
Probably worth investigating these CI failures. |
This seems to be related to the --only-dependencies flag of ci and the fact that I use a custom branch of persistent at the cabal.project. Eventually though we won't have a custom branch (unless we want this pr merged asap). |
40a80eb
to
b20787b
Compare
b20787b
to
8b21f06
Compare
Rebased and squashed down this PR. Hope it passes CI. |
8b21f06
to
1227676
Compare
Fixes #256 and maybe #397. There are two persistent issues that needs to be fixed before merging this
EXECUTE 'ALTER TABLE "block" DROP CONSTRAINT "block_previous_id_fkey"' ;
without replacing it with a correct one. It looks like a persistent bug, easy to fix.