Correct handling of rewards #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/issue-415
branch
2 times, most recently
from
96f54e9
to
f42a1c0
Compare
|
Still testing this. |
We have been pulling rewards from the ledger-state, *before* those rewards are distributed and its only when they are distributed that a reward address can be determined to be valid or not (and this happens inside ledger-state). What *can* happen is that a stake address is valid at the start of an given epoch (when the stake distribution snapshot is taken) but is then de-registered before the rewards for the epoch have been distributed. When this is the case these rewards go back to the reserves. However, to correctly calculate pool profitability we need to store both valid and invalid rewards in the database. We therefore need to separate the complete rewards set (actually a map) into two sets; the valid and the invalid rewards and store these in two separate tables.
This table contains rewards that could not be distributed to the relevant stake address because the stake address had been de-registered after the epoch started but before the rewards is distributed. Rewards listed in this table go back to the reserves. We need to keep both a 'Reward' and an 'OrphanedReward' table so that pool profitiabilty can be correctly calculated. Closes: #415 Closes: #467
This was referenced Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.