db: Add a field to the Tx table which holds the block index #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksaric
reviewed
May 18, 2020
There was a problem hiding this comment.
@erikd Could you just extend the migration to include the latest change as the new migration instead of dropping the whole migration path?
I have some code changes that depend on these migration paths and it's not trivial to change this.
This is the exact reason why we have migrations.
Update: After discussing this with Erik, I have accepted this to be fine in this instance since we have to iterate over the history of the blocks anyway, and it's safer since we are actually syncing the data from the blockchain.
This new field is the index of the transaction within a block. There is no easy way to write a migration for this, so the database needs to be dropped and recreated. Closes: #91
The addition of a 'block_index' column to the 'tx' table required that the database be dropped and recreated, so it makes sense to flatten the migrations in the same PR.
erikd
force-pushed
the
erikd/tx-index
branch
2 times, most recently
from
ef2ce4a
to
bb868af
Compare
Only update last row of the epoch table when the block being processed is within 15 blocks (5 minutes) of the tip. This improves sync speed of the current epoch.
rhyslbw
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.