Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch minFeeA parameter type to CoinPerByte #4262

Open
lehins opened this issue Apr 12, 2024 · 0 comments
Open

Switch minFeeA parameter type to CoinPerByte #4262

lehins opened this issue Apr 12, 2024 · 0 comments
Labels
🍰 good first issue Good for newcomers 💳 technical-debt Issues related to technical debt we introduced

Comments

@lehins
Copy link
Contributor

lehins commented Apr 12, 2024 •
edited

Current unit for minFeeA makes no sense, because we would get Coins square when computing the fee.

So, we need to use a better, but isomorphic type for it, which we already have: CoinPerByte
@lehins lehins added 🍰 good first issue Good for newcomers 💳 technical-debt Issues related to technical debt we introduced dijkstra Ledger era that will follow after Conway and removed dijkstra Ledger era that will follow after Conway labels Apr 12, 2024
This was referenced Apr 12, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍰 good first issue Good for newcomers 💳 technical-debt Issues related to technical debt we introduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lehins