Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Imp tests have realistic initial SPO thresholds #4329

Open
teodanciu opened this issue May 8, 2024 · 0 comments
Open

Ensure Imp tests have realistic initial SPO thresholds #4329

teodanciu opened this issue May 8, 2024 · 0 comments

Comments

@teodanciu
Copy link
Contributor

At the moment, SPO thresholds are not being set in the conway Imp initialization, so this means all SPO thresholds are set to 0 .
Some tests that need to check SPO behavior is setting them to something else.

But it would be more realistic to have them set to non-zero for all tests, so that we are always aware in tests of the SPOs (and if necessary, set them explicitly, in each case, to 0 if necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant