Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction view --> "Add collateral inputs friendly output" #942

Closed
5 of 8 tasks
dorin100 opened this issue Mar 1, 2022 · 1 comment · Fixed by #948
Closed
5 of 8 tasks

transaction view --> "Add collateral inputs friendly output" #942

dorin100 opened this issue Mar 1, 2022 · 1 comment · Fixed by #948
Assignees
Labels

Comments

@dorin100
Copy link
Collaborator

dorin100 commented Mar 1, 2022

related to IntersectMBO/cardano-node#3463

Whats new?
Now the cli command transaction view have a new parameters on the output named collateral inputs.

What is expected?
The new field should be null if no tx collateral's inputs are provided or present it in contrary case.

Scenarios:

  • no collateral in the tx (= existing tests --> it should not display any info in the new fields)
  • 1 valid collateral
  • multiple valid collaterals
  • check tx view command for raw, signed and submitted txs
  • collaterals from different payment addresses
  • mix of valid and invalid collaterals
  • other scenarios ?
  • use all the cases both with transaction build and transaction build-raw
@dorin100 dorin100 added the node label Mar 1, 2022
@saratomaz saratomaz self-assigned this Mar 1, 2022
@saratomaz
Copy link
Collaborator

To test the "transaction view" command we need a valid transaction, so is not possible to test the command with invalid data. Even so, new tests are added to check invalid transactions submission, one with an invalid utxo as collateral and one with an insufficient collateral amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants